-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fuzz Testing: Clarity value sanitization and serialization #3780
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3780 +/- ##
========================================
Coverage 0.18% 0.18%
========================================
Files 306 306
Lines 280746 280746
========================================
Hits 512 512
Misses 280234 280234
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
78f7652
to
b6c86ab
Compare
c08ccaa
to
695ff36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my feedback!
695ff36
to
103c8c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
103c8c8
to
5758e9b
Compare
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
This PR adds a
cargo fuzz
target that instruments and makes some assertions about the 2.4-enabled clarity value sanitization as well as existing serialization and deserialization routines.Unlike previous fuzzing PRs, this one does not need to make any changes in the
clarity
module: implementation ofArbitrary
is done in the fuzzing module itself.Additional info (benefits, drawbacks, caveats)
This PR (apart from a
warn -> debug
log downgrade) does not make any changes to the codebase, it just adds new testing coverage. This could also be used a starting point for future fuzz testing (see discussion #3732)