Refactor: PoX lock handling into separate workspace member #3793
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a refactor that moves the PoX lock handling into a separate workspace member.
This was a pretty simple set of operations to lift: they did not depend on any non-public members and the only circular dependency possibility was the use of ChainstateError in some of the methods. ChainstateError wasn't really necessary (and in some cases, was doing like a
ClarityError(ChainstateError(ClarityError)))
error wrapping), so this PR uses its own LockingError enum instead in those places.The reason for this refactoring (beyond the fact that it's easy to do, and separates some complexity from the StacksChainstate struct) is to support something like my PR on the clarinet repo (hirosystems/clarinet#1074) without code duplication (i.e., the ability to evaluate the PoX locks in clarinet).