Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use nextest for unit tests, disable grcov collation and codecov o… #3811

Merged
merged 12 commits into from
Jul 27, 2023

Conversation

kantai
Copy link
Member

@kantai kantai commented Jul 27, 2023

Description

Units tests are currently taking ~5 hours to run. This PR alters the execution of the unit tests CI task to use cargo nextest instead of cargo test. This should speed things up pretty significantly (from 5 hours down to 1.5). I can't get grcov to work quite right with this yet, but since pretty much all PRs are stalled due to the unit test run time, getting this change out seems important enough to disable unit test coverage for now.

Applicable issues

@kantai kantai requested review from jcnelson and wileyj July 27, 2023 11:14
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #3811 (8c62f91) into develop (e150653) will decrease coverage by 0.01%.
Report is 1 commits behind head on develop.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #3811      +/-   ##
===========================================
- Coverage     0.18%    0.18%   -0.01%     
===========================================
  Files          301      301              
  Lines       278533   278555      +22     
===========================================
  Hits           512      512              
- Misses      278021   278043      +22     
Files Changed Coverage Δ
src/clarity_vm/tests/analysis_costs.rs 0.00% <0.00%> (ø)
src/clarity_vm/tests/costs.rs 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

grcov . --binary-path ./target/debug/ -s . -t lcov --branch --ignore-not-existing --ignore "/*" -o lcov.info
- name: Upload codecov results
# grcov doesn't work with cargo nextest currently, getting
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. i'll have to double check my fork - i was under the impression this was working in that fork's workflows. lack of an error != it's working though, so i'll verify that.

Copy link
Contributor

@wileyj wileyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@kantai
Copy link
Member Author

kantai commented Jul 27, 2023

@wileyj -- this doesn't really seem like it's going to be sufficient, unfortunately. It looks like the unit tests are still taking a pretty long time, but also the github runner is just dying or disconnecting without any logging.

@kantai
Copy link
Member Author

kantai commented Jul 27, 2023

Screenshot 2023-07-27 at 1 33 22 PM

@kantai
Copy link
Member Author

kantai commented Jul 27, 2023

Just to reiterate, getting this fixed is blocking basically any progress on the blockchain workstreams at the moment -- there's > 30 open PRs, many of which could be merged, but cannot be progressed because the CI testing is broken.

@kantai kantai merged commit 2c115c6 into develop Jul 27, 2023
1 check passed
@kantai kantai deleted the ci/nextest-units branch July 27, 2023 22:24
@wileyj
Copy link
Contributor

wileyj commented Jul 28, 2023

@wileyj -- this doesn't really seem like it's going to be sufficient, unfortunately. It looks like the unit tests are still taking a pretty long time, but also the github runner is just dying or disconnecting without any logging.

I think this was a transient error, i've never seen an error like this on any workflow run.
i've restarted the workflow that failed in your screenshot to see what happens, if there's any signal of what might have happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants