-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use nextest for unit tests, disable grcov collation and codecov o… #3811
Conversation
…n unit tests for now
Codecov Report
@@ Coverage Diff @@
## develop #3811 +/- ##
===========================================
- Coverage 0.18% 0.18% -0.01%
===========================================
Files 301 301
Lines 278533 278555 +22
===========================================
Hits 512 512
- Misses 278021 278043 +22
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
grcov . --binary-path ./target/debug/ -s . -t lcov --branch --ignore-not-existing --ignore "/*" -o lcov.info | ||
- name: Upload codecov results | ||
# grcov doesn't work with cargo nextest currently, getting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. i'll have to double check my fork - i was under the impression this was working in that fork's workflows. lack of an error != it's working though, so i'll verify that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shipit
@wileyj -- this doesn't really seem like it's going to be sufficient, unfortunately. It looks like the unit tests are still taking a pretty long time, but also the github runner is just dying or disconnecting without any logging. |
Just to reiterate, getting this fixed is blocking basically any progress on the blockchain workstreams at the moment -- there's > 30 open PRs, many of which could be merged, but cannot be progressed because the CI testing is broken. |
…erage from unit tests ci
I think this was a transient error, i've never seen an error like this on any workflow run. |
Description
Units tests are currently taking ~5 hours to run. This PR alters the execution of the unit tests CI task to use
cargo nextest
instead ofcargo test
. This should speed things up pretty significantly (from 5 hours down to 1.5). I can't get grcov to work quite right with this yet, but since pretty much all PRs are stalled due to the unit test run time, getting this change out seems important enough to disable unit test coverage for now.Applicable issues
nextest
and faster action runners for unit tests task #3808