Move blockstack-core into a separate folder (develop branch)

[sergey-shandar]

Description

Applicable issues

• fixes Top level Cargo.toml file shouldn't have package properties. #3809

Additional info (benefits, drawbacks, caveats)

Checklist

• Test coverage for new or modified code paths
• Changelog is updated
• Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
• New clarity functions have corresponding PR in clarity-benchmarking repo
• New integration test(s) added to bitcoin-tests.yml

[codecov]

Codecov Report

Merging #3814 (e4a9632) into develop (b820596) will decrease coverage by 0.02%.
Report is 4 commits behind head on develop.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #3814      +/-   ##
===========================================
- Coverage     0.18%    0.16%   -0.02%     
===========================================
  Files          306      305       -1     
  Lines       280746   280694      -52     
===========================================
- Hits           512      469      -43     
+ Misses      280234   280225       -9     

Files Changed	Coverage Δ
clarity/src/vm/types/serialization.rs	0.00% <0.00%> (ø)
stackslib/src/blockstack_cli.rs	0.00% <0.00%> (ø)
stackslib/src/burnchains/affirmation.rs	0.00% <ø> (ø)
stackslib/src/burnchains/bitcoin/address.rs	0.00% <ø> (ø)
stackslib/src/burnchains/bitcoin/bits.rs	0.00% <ø> (ø)
stackslib/src/burnchains/bitcoin/blocks.rs	0.00% <ø> (ø)
stackslib/src/burnchains/bitcoin/indexer.rs	0.00% <ø> (ø)
stackslib/src/burnchains/bitcoin/mod.rs	0.00% <ø> (ø)
stackslib/src/burnchains/bitcoin/network.rs	0.00% <ø> (ø)
stackslib/src/burnchains/bitcoin/spv.rs	0.00% <ø> (ø)
... and 132 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[sergey-shandar]

@kantai, @jcnelson, @stjepangolemac the CI is passing now for the PR.

[stjepangolemac]

Looks good. Do you think we could fit changing dependencies to workspace ones in this PR? Maybe it's better to leave that for another day.

[jcnelson]

`blockstack` is a name we shouldn't be using anymore. Please rename to `stackslib` or something like that to reflect the system's current name.

…

On Thu, Aug 3, 2023, 9:35 AM Stjepan Golemac ***@***.***> wrote: ***@***.**** approved this pull request. Looks good. Do you think we could fit changing dependencies to workspace ones in this PR? Maybe it's better to leave that for another day. — Reply to this email directly, view it on GitHub <#3814 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADQJK557VZXVAEPUZMQ3RTXTOSI3ANCNFSM6AAAAAA233U2VM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[jcnelson]

See earlier emailed comment

[jcnelson]

The only changes to Cargo.lock should be changing blockstack-core to stackslib.

[sergey-shandar]

The only changes to Cargo.lock should be changing blockstack-core to stackslib.

How often do we update Cargo.lock? Do we have separate PRs for this type of changes? Or are we stuck with the old versions of packages?

@AshtonStephens here's another example of Cargo.lock in the repo.

[jcnelson]

How often do we update Cargo.lock? Do we have separate PRs for this type of changes? Or are we stuck with the old versions of packages?

We change versions when it's necessary to make progress or to fix disclosed vulnerabilities. I make it a point to look through the code for each dependency so I know what we're responsible for maintaining.

[sergey-shandar]

Looks good. Do you think we could fit changing dependencies to workspace ones in this PR? Maybe it's better to leave that for another day.

I would make it as a separate PR(s). Issue #3834

[jcnelson]

Overall LGTM now, but please make that one change about opt-level before merging. Thanks!

[kantai]

Hmm.

This PR radically slowed down the unit test time -- went from ~40 minutes to now about 100 minutes.

[sergey-shandar]

Hmm.

This PR radically slowed down the unit test time -- went from ~40 minutes to now about 100 minutes.

It could be related to the opt-level #3835

[sergey-shandar]

Hmm.

This PR radically slowed down the unit test time -- went from ~40 minutes to now about 100 minutes.

@kantai check this PR #3838 if it fixes the issue.

[blockstack-devops]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.