-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/stackerdb rpc #3848
Feat/stackerdb rpc #3848
Conversation
…ks, and listing chunk metadata in a stackerdb
…unk metadata in stackerdb
…tead, do this to throttle senders
…ceed directly to chunk-get
Codecov Report
@@ Coverage Diff @@
## develop #3848 +/- ##
===========================================
- Coverage 0.16% 0.16% -0.01%
===========================================
Files 319 322 +3
Lines 285503 287639 +2136
===========================================
Hits 469 469
- Misses 285034 287170 +2136
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hi reviewers, I'm not sure why yet, but the "Full Genesis Test" only fails due to EDIT: the core issue is that the miner does not find UTXOs, which is weird. I'll try to reproduce locally. EDIT 2: I was unable to reproduce locally even when using the very same |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…erver, not just chunk metadata
…only forward stackerdb events to stackerdb-subscribed event observers
#[cfg(test)] | ||
mod tests; | ||
|
||
#[derive(Debug)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of this could be simplified if we use thiserror. Not sure if there is a reason we currently don't use it throughout the code base though.
@@ -1074,6 +1077,35 @@ simulating a miner. | |||
process::exit(0); | |||
} | |||
|
|||
if argv[1] == "post-stackerdb" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than manually parsing args, can we use something like clap?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple comments about cleanup but are not blockers by any means.
…erver Feat/stackerdb event observer
This PR implements the RPC interface for StackerDB.
This is a WIP for the next few days as more product requirements and stakeholder feedback are gathered and addressed. Also, the API documentation needs to be written.