Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid cloning double reference & remove unnecessary clone #3853

Merged

Conversation

bestmike007
Copy link
Contributor

Description

This PR is to address the using .clone() on a double reference compiler warning.

image

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #3853 (19d5c92) into develop (3af3051) will increase coverage by 0.00%.
Report is 1 commits behind head on develop.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop    #3853   +/-   ##
========================================
  Coverage     0.16%    0.16%           
========================================
  Files          339      339           
  Lines       287388   287386    -2     
========================================
  Hits           469      469           
+ Misses      286919   286917    -2     
Files Coverage Δ
stackslib/src/chainstate/burn/db/sortdb.rs 0.00% <0.00%> (ø)
stackslib/src/chainstate/coordinator/tests.rs 0.00% <0.00%> (ø)
stackslib/src/chainstate/stacks/tests/mod.rs 0.00% <0.00%> (ø)
stackslib/src/net/chat.rs 0.00% <0.00%> (ø)
stackslib/src/net/neighbors/walk.rs 0.00% <0.00%> (ø)
stackslib/src/clarity_vm/database/marf.rs 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jcnelson jcnelson merged commit be302fa into stacks-network:develop Sep 29, 2023
1 check passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants