Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StackerDB DKG #3871

Closed
wants to merge 1 commit into from
Closed

StackerDB DKG #3871

wants to merge 1 commit into from

Conversation

xoloki
Copy link
Collaborator

@xoloki xoloki commented Aug 23, 2023

Description

Applicable issues

  • fixes #

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@codecov
Copy link

codecov bot commented Aug 23, 2023 •
edited
Loading

Codecov Report

Merging #3871 (11de007) into develop (9b85505) will not change coverage.
Report is 52 commits behind head on develop.
The diff coverage is n/a.

❗ Current head 11de007 differs from pull request most recent head 252b5b8. Consider uploading reports for the commit 252b5b8 to get more accurate results

@@           Coverage Diff            @@
##           develop    #3871   +/-   ##
========================================
  Coverage    58.31%   58.31%           
========================================
  Files            1        1           
  Lines          571      571           
========================================
  Hits           333      333           
  Misses         238      238

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

xoloki
xoloki commented Aug 23, 2023
View reviewed changes
testnet/stacks-node/src/tests/neon_integrations.rs
}
}

pub trait Signable {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the start of the actual PR

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is just a placeholder but this code wouldbe pulled out into a lib somewhere that this integration test would use?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not meant to be a serious PR, just a PoC. Everything before the test itself is code ripped out of stacks-sbtc and minimally modified. With everything in flux now I have no idea where anything should live.

@jferrant jferrant mentioned this pull request Aug 29, 2023
Closed
@xoloki
add neon integration test that uses stackerdb to run dkg
252b5b8 
start building contract and params programmatically so we can change the number of signers and keys arbitrarily

build everything programmatically; increase the number of signers and keys

implement dkg private shares including encryption

dkg works, secrets compute for all signers

add ecdsa sign/verify for DkgBegin message; don't hardcode number of slots per stacker when making stackerDB contract

sign/verify DkgPublicShares and DkgPrivateShares
@jferrant
Copy link
Collaborator

Replaced by #3911

@jferrant jferrant closed this Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jferrant jferrant jferrant left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xoloki @jferrant