-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup stacks-signer by adding thiserror and documentation #3883
Conversation
Codecov Report
@@ Coverage Diff @@
## feat/stacks-signer #3883 +/- ##
===================================================
Coverage 0.16% 0.16%
===================================================
Files 339 339
Lines 290265 290213 -52
===================================================
Hits 469 469
+ Misses 289796 289744 -52
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hey @jferrant, this looks like it's otherwise ready to go, but it has a few merge conflicts. Can you resolve these and merge this PR when you get a moment? Thanks! |
Oh completely forgot I had this open . yes will do right now. |
Signed-off-by: Jacinta Ferrant <[email protected]>
0e1a20a
to
439d4fe
Compare
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Changes:
Alphabetically order cargo.toml dependencies
Forbids no documentation
Adds a README to be filled in as the CLI and SDK is expanded.
Addresses a bunch of random clippy warnings.
Uses thiserror to simplify boiler plate code for error definitions/formatting.
This PR addresses part of #3882
Please add reviewers as you see fit who may have a strong opinion for or against thiserror or the use of a different crate.