Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix CI failing when we don't have DockerHub credentials #3909

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

jbencin
Copy link
Contributor

@jbencin jbencin commented Sep 11, 2023

Description

Cherry-picked from #3888, this is similar to #3905 but for the master branch

Copy link
Contributor

@wileyj wileyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #3909 (14e7166) into master (eca1cfe) will decrease coverage by 25.36%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #3909       +/-   ##
===========================================
- Coverage   58.31%   32.95%   -25.36%     
===========================================
  Files           1      301      +300     
  Lines         571   277122   +276551     
===========================================
+ Hits          333    91336    +91003     
- Misses        238   185786   +185548     

see 300 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jbencin jbencin merged commit fe45e91 into master Sep 13, 2023
1 check failed
@jbencin jbencin deleted the ci/pass-without-dockkerhub-credentials-on-master branch September 13, 2023 20:36
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants