-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send Signer results over a channel #3923
Conversation
Codecov Report
@@ Coverage Diff @@
## feat/stacks-signer #3923 +/- ##
======================================================
- Coverage 0.16% 0.16% -0.01%
======================================================
Files 339 339
Lines 290170 290260 +90
======================================================
Hits 469 469
- Misses 289701 289791 +90
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the state machine substantially and fixed the test to actually tear down the signers at the end. My initial check on the meaty portion (following node and signer setup), it takes ~15 seconds to run DKG and Sign a message.
040bb55
to
17e8615
Compare
…s interested; remove sleep calls in test since we know when it's done
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
888f04d
to
df88955
Compare
I fixed the build so we don't expect any additional types to |
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for addressing my comments!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Right now the only way to find out what a
Signer
has done is to stop it and get the cached results.Add another channel which lets
Signer
send results as they come in.Applicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/rpc/openapi.yaml
andrpc-endpoints.md
for v2 endpoints,event-dispatcher.md
for new events)clarity-benchmarking
repobitcoin-tests.yml