Bugfix/nakamoto coordinator reward set prepare phase calcs

[jferrant]

Description

This pulls some bugfixes out of other branches that have discovered them:

• The first commit was cherry picked from feat/nakamoto-validate-signer
• The second commit was taken from feat/mockamoto-mining-redux

Fixes

• off by one bug in find_prepare_phase_sortitions which incorrectly included one BEFORE prepare phase in the list of sortitions
• off by one bug in get_reward_set_nakamoto which was incorrectly using the current reward cycle rather than the NEXT reward cycle for getting reward addresses. This bug was due to change in assumptions in Nakamoto vs pre-Nakamoto: Nakamoto calculates reward set DURING the prepare phase of the PRIOR reward cycle whereas pre-Nakamoto calculated reward set at the START of the CURRENT reward cycle.

[codecov]

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (252b77f) 0.04% compared to head (1bb5331) 0.04%.
Report is 1 commits behind head on next.

Files	Patch %	Lines
...ackslib/src/chainstate/nakamoto/coordinator/mod.rs	0.00%	13 Missing ⚠️
stackslib/src/chainstate/stacks/boot/mod.rs	0.00%	12 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             next    #4095   +/-   ##
=======================================
  Coverage    0.04%    0.04%           
=======================================
  Files         419      419           
  Lines      297643   297652    +9     
=======================================
  Hits          136      136           
- Misses     297507   297516    +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[xoloki]

LGTM, but I'm not at all familiar with the code that's changed, so someone who is needs to review it before merge

[jcnelson]

LGTM!

[blockstack-devops]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.