-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable FIRE
coordinator for stacks-signer
#4174
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## next #4174 +/- ##
==========================================
- Coverage 82.91% 77.17% -5.75%
==========================================
Files 429 429
Lines 302067 302091 +24
==========================================
- Hits 250458 233128 -17330
- Misses 51609 68963 +17354 ☔ View full report in Codecov by Sentry. |
…fault frost coordinator
…uct HashSet based signer_key_ids when creating CoordinatorConfig
2711bf6
to
fa97aa8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shipit
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
stacks-signer
is currently using a very basicwsts
Coordinator
implementation that doesn't handle non-responsive or malicious signers. This has been fine for testing so far, but for Nakamoto we will need to sign all blocks usingwsts
, so we have to handle these and other errors.wsts
has a betterCoordinator
which supports theFIRE
meta-protocol; it uses timeouts to handle non-responsive signers, returns errors identifying malicious signers, and correctly identifies when the number of malicious and/or non-responsive signers is large enough to make progress on any round impossible.This PR therefore enables the
FIRE
coordinator.Applicable issues
FIRE
coordinator forsigner
#4169Additional info (benefits, drawbacks, caveats)
Checklist
docs/rpc/openapi.yaml
andrpc-endpoints.md
for v2 endpoints,event-dispatcher.md
for new events)clarity-benchmarking
repobitcoin-tests.yml