Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable FIRE coordinator for stacks-signer #4174

Merged
merged 7 commits into from
Dec 19, 2023
Merged

Conversation

xoloki
Copy link
Collaborator

@xoloki xoloki commented Dec 14, 2023

Description

stacks-signer is currently using a very basic wsts Coordinator implementation that doesn't handle non-responsive or malicious signers. This has been fine for testing so far, but for Nakamoto we will need to sign all blocks using wsts, so we have to handle these and other errors.

wsts has a better Coordinator which supports the FIRE meta-protocol; it uses timeouts to handle non-responsive signers, returns errors identifying malicious signers, and correctly identifies when the number of malicious and/or non-responsive signers is large enough to make progress on any round impossible.

This PR therefore enables the FIRE coordinator.

Applicable issues

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@xoloki xoloki self-assigned this Dec 14, 2023
@xoloki xoloki changed the base branch from master to next December 14, 2023 20:53
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (2789b18) 82.91% compared to head (fa97aa8) 77.17%.

Files Patch % Lines
stacks-signer/src/runloop.rs 0.00% 13 Missing ⚠️
stacks-signer/src/main.rs 0.00% 10 Missing ⚠️
testnet/stacks-node/src/tests/signer.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4174      +/-   ##
==========================================
- Coverage   82.91%   77.17%   -5.75%     
==========================================
  Files         429      429              
  Lines      302067   302091      +24     
==========================================
- Hits       250458   233128   -17330     
- Misses      51609    68963   +17354     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xoloki xoloki marked this pull request as ready for review December 19, 2023 08:15
@xoloki xoloki requested a review from jferrant December 19, 2023 08:15
stacks-signer/src/main.rs Outdated Show resolved Hide resolved
@saralab saralab requested a review from kantai December 19, 2023 18:47
Copy link
Contributor

@wileyj wileyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@xoloki xoloki merged commit 4001992 into next Dec 19, 2023
1 of 2 checks passed
@xoloki xoloki deleted the feat/fire-coordinator branch December 19, 2023 20:29
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable FIRE coordinator for signer
5 participants