Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DKG fully robust against non-participation #4236

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

xoloki
Copy link
Collaborator

@xoloki xoloki commented Jan 9, 2024

Description

Applicable issues

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@xoloki xoloki requested a review from jferrant January 9, 2024 15:08
@xoloki xoloki self-assigned this Jan 9, 2024
@xoloki xoloki changed the base branch from master to next January 9, 2024 15:11
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f359a17) 83.20% compared to head (b745833) 83.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #4236   +/-   ##
=======================================
  Coverage   83.20%   83.20%           
=======================================
  Files         432      432           
  Lines      306549   306549           
=======================================
  Hits       255066   255066           
  Misses      51483    51483           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like just an update to a rustdoc -- which is fine with me, but is this PR missing a commit?

@xoloki
Copy link
Collaborator Author

xoloki commented Jan 19, 2024

This looks like just an update to a rustdoc -- which is fine with me, but is this PR missing a commit?

This PR is a placeholder until we publish wsts 7.0, which should happen tomorrow. I originally created it to test whether CI was working on the next branch for @jferrant

@jcnelson jcnelson merged commit 5084a33 into next Jan 19, 2024
2 checks passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Nakamoto] Stacker-Signer binary must handle non-participation
5 participants