Chore/update wsts version 7 #4267
Conversation
Signed-off-by: Jacinta Ferrant <[email protected]>
jferrant
force-pushed
the
chore/update-wsts-version-7
branch
from
5a7fdae
to
437d8fa
Compare
| @@ -36,7 +36,7 @@ use wsts::state_machine::PublicKeys; | |||
| /// List of key_ids for each signer_id | |||
| pub type SignerKeyIds = HashMap<u32, Vec<u32>>; | |||
|
|
|||
| const EVENT_TIMEOUT_MS: u64 = 5000; | |||
| const EVENT_TIMEOUT_MS: u64 = 50; | |||
There was a problem hiding this comment.
That's a little small, don't you think?
There was a problem hiding this comment.
The issue here is that the libsigner runloop has to multiplex two event receivers: one with stackerdb events, the other with main loop commands. So every time we would get an event without a command, we'd wait 5 seconds for a command that never came.
I'm still not exactly sure why this was suddenly a problem. wsts v7 added a DkgEndBegin message, which is being amplified by all of the inactive coordinators, so presumably that was it. But I have no idea why we weren't often hitting this issue, since we don't send many commands but received lots of messages even before this change.
Regardless, this was always broken before, so the fix seems appropriate.
There was a problem hiding this comment.
I think once we remove the command receiver, we can update it back to 5000 ms. However, for now I think this fix is okay. If we find we need to KEEP the command receiver we should have a sep timeout for it :)
The command receiver was just a temporary change to enable us to test things while the node did not have the state necessary to trigger DKG / sign rounds.
|
Just had one question about the timeout -- 50ms is a little small for network latency across the broad internet. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #4267 +/- ##
===========================================
- Coverage 83.34% 58.99% -24.35%
===========================================
Files 432 432
Lines 306549 306557 +8
===========================================
- Hits 255484 180867 -74617
- Misses 51065 125690 +74625 ☔ View full report in Codecov by Sentry. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Update wsts version to 7 to enable DKG robustness and voting no on a block
NOTE: also fixes slowdown due to double wait for command events using the poll_timeout