fix: modify test_simple_signer to fix intermittent failure #4306
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4280 modified a test in
libsigner
to test the/status
endpoint. Because I didn't realize that the test signer thread was configured to exit after 5 events, I designed the test wrongly. Tests would pass locally and sometimes on CI, but I realized later that the tests would sometimes fail in CI because a thread would receive an event before it was shutdown.This PR:
/status
endpoint testing in the original test