feat: add signer CLI function to generate signature

[hstove]

This PR adds a new command to the stacks-signer CLI:

stacks-signer generate-stacking-signature \
  --pox-address bc123... \
  --reward-cycle 100 \
  --config ./config.toml \
  --period 12 \
  --topic stack-stx

This is built on top of #4277, which isn't merged yet, so I'm opening this as a draft until that PR is reviewed and merged.

• closes Signer CLI command to generate Stacking transaction information #4302

[codecov]

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (be5ea05) 83.35% compared to head (38a7465) 83.35%.

Files	Patch %	Lines
stacks-signer/src/cli.rs	58.33%	30 Missing ⚠️
stacks-signer/src/main.rs	93.84%	8 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #4319      +/-   ##
==========================================
- Coverage   83.35%   83.35%   -0.01%     
==========================================
  Files         446      446              
  Lines      318545   318774     +229     
==========================================
+ Hits       265539   265721     +182     
- Misses      53006    53053      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jferrant]

LGTM :D Thankss for doing this!

[zone117x]

It would be useful to have test vectors with hex strings, e.g. containing the serialized payload for this struct. That way other folks could leverage the same vectors to be more confident in their implementation (like in a js one).

Not super important though unless we actually envision needing to implement similar code in js any time soon.

[zone117x]

LGTM, thanks @hstove!

[jcnelson]

Thanks for this @hstove! Is there a way to test this in an integration test, so as to verify that the output of this command can be used in pox-4 for a stacking signature?

[hstove]

Is there a way to test this in an integration test, so as to verify that the output of this command can be used in pox-4 for a stacking signature?

Good call, added!

[blockstack-devops]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.