Fix flaky block-proposal test #4337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kantai
approved these changes
Feb 2, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## next #4337 +/- ##
==========================================
+ Coverage 83.23% 83.25% +0.02%
==========================================
Files 443 443
Lines 316885 316901 +16
==========================================
+ Hits 263749 263838 +89
+ Misses 53136 53063 -73 ☔ View full report in Codecov by Sentry. |
jferrant
approved these changes
Feb 3, 2024
|
Glad you caught this! LGTM |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the flakiness in
miner_writes_proposed_block_to_stackerdb.