Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont warn about aggregate key in 2.5 #4626

Merged
merged 1 commit into from
Apr 6, 2024
Merged

Conversation

hstove
Copy link
Contributor

@hstove hstove commented Apr 2, 2024

This changes the warn_if_not_found_flag from hard-coded true to an epoch comparison.

@hstove hstove linked an issue Apr 2, 2024 that may be closed by this pull request
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.23%. Comparing base (c383bdd) to head (0713b65).

Additional details and impacted files
@@             Coverage Diff             @@
##             next    #4626       +/-   ##
===========================================
- Coverage   83.15%   66.23%   -16.93%     
===========================================
  Files         470      470               
  Lines      332698   332702        +4     
  Branches      317      317               
===========================================
- Hits       276663   220350    -56313     
- Misses      56027   112344    +56317     
  Partials        8        8               
Files Coverage Δ
stackslib/src/chainstate/nakamoto/mod.rs 80.28% <100.00%> (-2.51%) ⬇️

... and 279 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c383bdd...0713b65. Read the comment docs.

Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: typo artifact. LGTM

@kantai kantai added this pull request to the merge queue Apr 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 4, 2024
@obycode obycode added this pull request to the merge queue Apr 6, 2024
Merged via the queue into next with commit 5d2cbdd Apr 6, 2024
1 of 2 checks passed
@hstove hstove deleted the fix/aggregate-key-warning branch April 9, 2024 19:43
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce constant logging of "failed to get aggregate key"
6 participants