-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dont warn about aggregate key in 2.5 #4626
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #4626 +/- ##
===========================================
- Coverage 83.15% 66.23% -16.93%
===========================================
Files 470 470
Lines 332698 332702 +4
Branches 317 317
===========================================
- Hits 276663 220350 -56313
- Misses 56027 112344 +56317
Partials 8 8
... and 279 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EDIT: typo artifact. LGTM
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This changes the
warn_if_not_found_flag
from hard-codedtrue
to an epoch comparison.