remove portable flag #4646
remove portable flag #4646
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #4646 +/- ##
==========================================
- Coverage 83.37% 83.20% -0.17%
==========================================
Files 470 470
Lines 332981 332981
Branches 317 317
==========================================
- Hits 277627 277068 -559
- Misses 55346 55905 +559
Partials 8 8 see 51 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
it's mentioned in the ref ticket #4638 - it was silently being ignored and the docs aren't very up front about it. |
good catch - i think it should be fine, since this is mostly needed for release builds (and should make it's way to develop soon anyways) |
* upstream/main: (26 commits) link on summary the documentation on how to fix the mutants' output mutants: add link to summary on failed output job cases documentation how mutants output should be treated fix: run one test at a time fix(rustfmt): Exit script with error code on failure fix(rustfmt): Read `rustfmt` alias from `.cargo/config` or `.cargo/config.toml` feat: remove `./` feat: check if release dir exists before trying to access it feat: setup rustfmt in composite actions feat: get rid of the `release/` path in the generated checksums fix: remove leftover git diff file feat: upload and download artifacts under different names feat: update all actions versions used more whitepsace removal remove whitespace remove portable build flag remove portable stacks-network/stacks-core#4646 change to check for unviable from inexistent file to empty file remove conditional build build all binaries and copy them with find where possible (macos arm64 is outlier) ...
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
ref: #4638
the options in .cargo/config are not being applied, this PR removes them entirely and adds some text in the README on how to enable building for
native-cpu.removing the portable flag will have some downstream effects to the release build process that we'll need to address once merged (basically removing the portable feature flag, and re-enabling macos-arm64 stacks-signer binary builds).