Feat/signers read stackerdb #4658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
…overwritten so its impossible to do properly Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
jferrant
commented
Apr 8, 2024
kantai
previously approved these changes
Apr 8, 2024
Yeah, I am not 100% sure why this is the case. I actually can't merge this until #4654 is done. So will keep this as is for now and will look into it further when that PR is completed. |
hstove
previously approved these changes
Apr 9, 2024
jferrant
dismissed stale reviews from hstove and kantai
The base branch was changed.
… into feat/signers-read-stackerdb
Signed-off-by: Jacinta Ferrant <[email protected]>
… follow Signed-off-by: Jacinta Ferrant <[email protected]>
hstove
previously approved these changes
Apr 19, 2024
… into feat/signers-read-stackerdb
Signed-off-by: Jacinta Ferrant <[email protected]>
… into feat/signers-read-stackerdb
…ger next steps Signed-off-by: Jacinta Ferrant <[email protected]>
jferrant
force-pushed
the
feat/signers-read-stackerdb
branch
from
32b548b
to
ff96f8c
Compare
xoloki
approved these changes
Apr 25, 2024
hstove
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Nice job. A little nit regarding comments / logs, and that may be to me misunderstanding things. It shouldn't be blocking a merge, but a few more comments around why this state happened in refresh/update DKG would be help.
Also, I was going to comment "nice job on that test" but I already did 😂
jcnelson
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4636
Attempted to do for sign as well, but this would require substantial changes to the way a miner stores its messages as we require every single sign message to replicate state and miners overwrite their own messages as they use the same slot for everything. Sign rounds are also quite quick and a miner already has timeout logic in place for triggering a new sign request, so this is less of an issue anyway.