-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hex Encode signer CLI outputs from StackerDB chunks #4661
Conversation
I think the standard we use when printing binary data to the terminal in the stacks core is to just convert everything to hex (though base64 also works). I think we can just do that. I would hexify it and i think we already have a to_hex function or something like that which shouldbe accessible from the signer. Maybe update the helper messages for each CLI command to indicate that it prints the chunk data in hex |
Yeah, seconded -- this should be hex or base64. If the user wants to convert to binary, they can pipe it into |
Side note, this will have to be reopened against develop as soon as Brice finishes merging next into develop . See https://nakamotoslack.slack.com/archives/C067BHSN1SL/p1712679342282899 |
@jferrant @jcnelson |
I think it can be the user's responsibility to escape the output :) |
@jferrant Updated the base branch for the PR |
d813138
to
fbe90ed
Compare
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Hex encoding StackerDB chunks before writing to terminal to address audit security issue.
Applicable issues