Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add startup logging with config to signer #4678

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

hstove
Copy link
Contributor

@hstove hstove commented Apr 11, 2024

This adds a simple log when the signer is started with the signer's configuration information. The goal is just to help signers ensure their signer is configured as expected. It also provides the signer's STX address and public key.

I've also added a check-config command which validates a config file and outputs the same startup logging information.

xoloki
xoloki previously approved these changes Apr 11, 2024
Copy link
Collaborator

@xoloki xoloki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wileyj
Copy link
Contributor

wileyj commented Apr 12, 2024

@hstove if you want this in the next rc, can you rebase and PR against release/2.5.0.0.0?

@hstove
Copy link
Contributor Author

hstove commented Apr 12, 2024

@wileyj I've made #4679 which targets the release branch. I figured we should keep both PRs to prevent mismatch between develop and release. If that's not a problem we can close the PR.

@wileyj wileyj merged commit 420bf32 into develop Apr 12, 2024
1 check passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[stacks-signer] add clean logging to the signer for a signer that has been successfully configured
6 participants