Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade transaction warnings #4697

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Downgrade transaction warnings #4697

merged 2 commits into from
Apr 19, 2024

Conversation

obycode
Copy link
Contributor

@obycode obycode commented Apr 18, 2024

Description

These problems with transactions are normal and should not be warnings in the stacks-node logs. They are flooding the logs with warnings, making it easier to miss real warnings.

Applicable issues

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

These problems with transactions are normal and should not be warnings
in the stacks-node logs. They are flooding the logs with warnings,
making it easier to miss real warnings.
@obycode
Copy link
Contributor Author

obycode commented Apr 18, 2024

I'll add an entry in the changelog after master is merged into develop.

@obycode obycode requested review from kantai and a team and removed request for a team April 18, 2024 23:47
Copy link
Member

@diwakergupta diwakergupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@obycode obycode merged commit 9d3722a into develop Apr 19, 2024
1 of 2 checks passed
@obycode obycode deleted the chore/downgrade-warnings branch April 19, 2024 02:26
obycode added a commit that referenced this pull request May 1, 2024
Downgraded log messages about transactions from warning to info.
@obycode obycode mentioned this pull request May 1, 2024
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants