Merge master into release/2.5.0.0.0 #4715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Charlie <[email protected]>
fix: Use finite set of strings for HTTP metrics
|
I cherry-picked f95620d on top of this as well. |
Merged
|
Can you open this against |
obycode
changed the title
kantai
previously approved these changes
Apr 25, 2024
jbencin
previously approved these changes
Apr 25, 2024
Rearrange the methods to be in the same order, and change some parameter names to be more consistent.
jbencin
previously approved these changes
Apr 25, 2024
jcnelson
previously approved these changes
Apr 25, 2024
|
Oops. Looks like I need to update |
jbencin
reviewed
Apr 25, 2024
obycode
force-pushed
the
chore/master-to-2.5.0.0.0
branch
from
f601799
to
c2dcdde
Compare
kantai
approved these changes
Apr 25, 2024
jbencin
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the title explains it.