Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solo Stacking stateful property-based tests #4725

Merged
merged 13 commits into from
Apr 30, 2024

Conversation

BowTiedRadone
Copy link
Contributor

Description

This PR is a continuation of #4550. It adds the solo stacking scenarios to the stateful property-based testing strategy for PoX-4.

Applicable issues

moodmosaic
moodmosaic previously approved these changes Apr 26, 2024
Copy link
Member

@moodmosaic moodmosaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 This follows the same strategy we used for the pool delegate stacking scenarios.

@hugocaillard
Copy link
Collaborator

@moodmosaic @BowTiedRadone What do you think about including these changes in this PR
#4550 (comment)

@moodmosaic
Copy link
Member

@moodmosaic @BowTiedRadone What do you think about including these changes in this PR #4550 (comment)

That's the plan. It will be in a folder boot-contracts-stateful-prop-tests:

moodmosaic added a commit that referenced this pull request Apr 29, 2024
- Move PoX-4 tests from ../core-contract-tests/tests/pox-4/ to
  boot-contracts-stateful-prop-tests/tests/pox-4.
- Set up a minimalistic vitest and Clarinet project.
- Adjust configurations for test isolation.
- Ensure Clarinet config is minimalistic as possible.
- See PR for more context: #4725 (comment)
- Relocate PoX-4 stateful property-based tests from
  ../core-contract-tests/tests/pox-4/ to
  boot-contracts-stateful-prop-tests/tests/pox-4.
- Implement a minimalistic vitest and Clarinet project setup.
- Adjust configurations for optimal test isolation.
- Ensure Clarinet config is as minimalistic as possible.
- For more details, see: #4725 (comment)
@moodmosaic moodmosaic force-pushed the feat/pox-4-stateful-solo-scenarios branch from 88d8bf2 to 482c195 Compare April 29, 2024 16:31
@moodmosaic moodmosaic self-requested a review April 29, 2024 16:34
Copy link
Collaborator

@hugocaillard hugocaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

Copy link
Collaborator

@friedger friedger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relocation of files makes sense.

Copy link
Member

@moodmosaic moodmosaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🪐

@moodmosaic moodmosaic added this pull request to the merge queue Apr 30, 2024
Merged via the queue into develop with commit 10d954c Apr 30, 2024
1 check passed
@moodmosaic moodmosaic deleted the feat/pox-4-stateful-solo-scenarios branch May 1, 2024 06:07
@moodmosaic moodmosaic restored the feat/pox-4-stateful-solo-scenarios branch May 1, 2024 06:07
@moodmosaic moodmosaic mentioned this pull request May 1, 2024
18 tasks
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants