Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] 4746 - Avoid extraneous CI runs (master) #4766

Merged
merged 2 commits into from
May 9, 2024
Merged

[CI] 4746 - Avoid extraneous CI runs (master) #4766

merged 2 commits into from
May 9, 2024

Conversation

wileyj
Copy link
Contributor

@wileyj wileyj commented May 8, 2024

Small change to the ci workflow to reduce the frequency of when CI is triggered.
previously, various workflows would trigger:

  • open a PR
  • new commits to a PR
  • PR approvals
  • add PR to merge group
  • would not trigger if only change is yml/md

This change does the following:

  • workflow triggers when a PR:
    • is opened
    • is changed
    • only updated files are md/yml (this will be addressed in a future PR - today the required status checks would make this problematic)
  • workflow no longer runs:
    • when PR is approved

@wileyj wileyj mentioned this pull request May 8, 2024
Open
@wileyj wileyj requested a review from a team May 8, 2024 16:40
@wileyj wileyj self-assigned this May 8, 2024
@wileyj wileyj added the CI label May 8, 2024
hstove
hstove approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@hstove hstove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moment of truth - will it run when I approve?

obycode
obycode approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me!

@wileyj wileyj merged commit b7f7295 into master May 9, 2024
1 check passed
@wileyj wileyj deleted the fix/reduce_ci_runs-master branch May 9, 2024 18:10
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@obycode obycode obycode approved these changes

@hstove hstove hstove approved these changes

Assignees

@wileyj wileyj

Labels
CI locked
Projects
Stacks Core Eng
Status: Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wileyj @blockstack-devops @hstove @obycode