Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Preserve PeerNetwork during Epoch 3.0 transition #4767

Merged

Conversation

jbencin
Copy link
Contributor

@jbencin jbencin commented May 8, 2024

Description

Preserve PeerNetwork struct from Neon node and pass to Nakamoto node during Epoch 3.0 transition to maintain network connections

Applicable issues

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@jbencin jbencin force-pushed the feat/nakamoto-keep-peer-network branch from f8f96b3 to ce7ffbe Compare May 10, 2024 15:47
@jbencin
Copy link
Contributor Author

jbencin commented May 10, 2024

@kantai @jcnelson I'm having trouble thinking of a good way to test this. I'm not sure what I would check in PeerNetwork to prove it wasn't re-created, and I can't really access it from outside StacksNode::spawn() anyways. Right now I'm thinking I could use TestPeer, or just open a raw TCP socket, and check if it gets disconnected. Any better ideas?

@jbencin
Copy link
Contributor Author

jbencin commented May 10, 2024

Also the following tests are failing, but also fail on develop as of e79719d:

  • tests::nakamoto_integrations::follower_bootup
  • tests::signer::stackerdb_mine_2_nakamoto_reward_cycles

Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jcnelson jcnelson self-requested a review May 13, 2024 17:33
@jbencin jbencin force-pushed the feat/nakamoto-keep-peer-network branch from ce7ffbe to c65fa5c Compare May 13, 2024 17:47
@jbencin jbencin enabled auto-merge May 13, 2024 17:47
@jbencin jbencin added this pull request to the merge queue May 13, 2024
Merged via the queue into stacks-network:develop with commit 16cca4a May 13, 2024
1 check passed
@jbencin jbencin deleted the feat/nakamoto-keep-peer-network branch May 14, 2024 12:56
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants