fix: add missing methods to generate-stacking-signature
#4769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hstove
force-pushed
the
fix/signer-cli-stacking-methods
branch
from
1608720
to
0904dec
Compare
|
Rebased and ready for review 👍🏼 |
kantai
approved these changes
May 18, 2024
jferrant
approved these changes
May 23, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stack-aggregation-increasetopic is not exposed ingenerated-stacking-signature#4763The methods
stack-increaseandagg-increaseweren't included as valid options in thestacks-signer generate-stacking-signaturecommand.This PR updates the
clapargument type to do a direct lookup of the underlyingPox4SignatureTopic, so that no case can be missed. This PR also adds tests to ensure the various strings can be provided as valid options.