Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify nakamoto block header to use Vec<MessageSignature> #4781

Merged
merged 61 commits into from
Jun 4, 2024
Merged

modify nakamoto block header to use Vec<MessageSignature> #4781

merged 61 commits into from
Jun 4, 2024

Commits on May 16, 2024

  1. wip: modify nakamoto block header to use Vec<MessageSignature>

    @hstove
    hstove committed May 16, 2024
    Configuration menu
    Copy the full SHA
    8ac1193 View commit details
    Browse the repository at this point in the history

  2. feat: verify signatures in nakamoto block header

    @hstove
    hstove committed May 16, 2024
    Configuration menu
    Copy the full SHA
    fd0407b View commit details
    Browse the repository at this point in the history

  3. feat: refactor test_signers for new signer_signature type

    @hstove
    hstove committed May 16, 2024
    Configuration menu
    Copy the full SHA
    80e6853 View commit details
    Browse the repository at this point in the history

  4. feat: update sign_coordinator and blind_signer for new message types

    @hstove
    hstove committed May 16, 2024
    Configuration menu
    Copy the full SHA
    57c0db2 View commit details
    Browse the repository at this point in the history

  5. fix: code review comments 

    - use `vec![]` instead of `Vec::new()` or `Vec::with_capacity`
- Add a constant for the signer threshold
- Update threshold calculation
- Fix some unsafe unwraps / math
- Refactor how `TestSigner` signs a block using a reward set
    @hstove
    hstove committed May 16, 2024
    Configuration menu
    Copy the full SHA
    da6dad1 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. chore: fix compile-time issue

    @jcnelson
    jcnelson committed May 17, 2024
    Configuration menu
    Copy the full SHA
    e0f9052 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Merge branch 'feat/add-v0-signer' into feat/header-signer-signatures

    @hstove
    hstove committed May 20, 2024
    Configuration menu
    Copy the full SHA
    aaf8b93 View commit details
    Browse the repository at this point in the history

  2. crc: docstring, dead_code macro

    @hstove
    hstove committed May 20, 2024
    Configuration menu
    Copy the full SHA
    401d2d3 View commit details
    Browse the repository at this point in the history

  3. feat: gather v0 block signatures from stackerdb

    @hstove
    hstove committed May 20, 2024
    Configuration menu
    Copy the full SHA
    650c86c View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. feat: update metrics in v0 signer, add tests

    @hstove
    hstove committed May 21, 2024
    Configuration menu
    Copy the full SHA
    f72ecc8 View commit details
    Browse the repository at this point in the history

  2. fix: move reward_set loading to top-level BlockMinerThread

    @hstove
    hstove committed May 21, 2024
    Configuration menu
    Copy the full SHA
    aa9baf9 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. feat: better API for querying preprocessed reward sets (e.g. by rewar… 

    …d cycle ID, by sortition ID, etc.)
    @jcnelson
    jcnelson committed May 22, 2024
    Configuration menu
    Copy the full SHA
    2416c4b View commit details
    Browse the repository at this point in the history

  2. chore: fix 4813 by re-trying to store a reward set if it has 'selecte… 

    …d-and-unknown' status
    @jcnelson
    jcnelson committed May 22, 2024
    Configuration menu
    Copy the full SHA
    753f9c9 View commit details
    Browse the repository at this point in the history

  3. chore: blow away aggregate key verification code (it won't be used un… 

    …til a later date, and it's in the git history so we can fetch it later)
    @jcnelson
    jcnelson committed May 22, 2024
    Configuration menu
    Copy the full SHA
    ad1094b View commit details
    Browse the repository at this point in the history

  4. chore: API sync

    @jcnelson
    jcnelson committed May 22, 2024
    Configuration menu
    Copy the full SHA
    da60d06 View commit details
    Browse the repository at this point in the history

  5. chore: API sync

    @jcnelson
    jcnelson committed May 22, 2024
    Configuration menu
    Copy the full SHA
    67038a2 View commit details
    Browse the repository at this point in the history

  6. fix: search for the highest tenure from the block-processor's given s… 

    …ortition tip. Do not attempt to get the canonical stacks or burnchain tips.
    @jcnelson
    jcnelson committed May 22, 2024
    Configuration menu
    Copy the full SHA
    127165a View commit details
    Browse the repository at this point in the history

  7. feat: add a way to synthesize a reward set from a list of signers

    @jcnelson
    jcnelson committed May 22, 2024
    Configuration menu
    Copy the full SHA
    9bc3d55 View commit details
    Browse the repository at this point in the history

  8. chore: move unused code for loading the aggregate public key into a t… 

    …est module, where it is still required for test coverage
    @jcnelson
    jcnelson committed May 22, 2024
    Configuration menu
    Copy the full SHA
    b8e85e3 View commit details
    Browse the repository at this point in the history

  9. chore: API sync

    @jcnelson
    jcnelson committed May 22, 2024
    Configuration menu
    Copy the full SHA
    41c50fa View commit details
    Browse the repository at this point in the history

  10. chore: fmt

    @jcnelson
    jcnelson committed May 22, 2024
    Configuration menu
    Copy the full SHA
    f1d4657 View commit details
    Browse the repository at this point in the history

  11. chore: doc epoch2-specific behavior

    @jcnelson
    jcnelson committed May 22, 2024
    Configuration menu
    Copy the full SHA
    ffb572e View commit details
    Browse the repository at this point in the history

  12. chore: use reward sets instead of aggregate public keys

    @jcnelson
    jcnelson committed May 22, 2024
    Configuration menu
    Copy the full SHA
    f2fac09 View commit details
    Browse the repository at this point in the history

  13. chore: use reward set signature verification

    @jcnelson
    jcnelson committed May 22, 2024
    Configuration menu
    Copy the full SHA
    3fff20e View commit details
    Browse the repository at this point in the history

  14. chore: use reward set signature verification

    @jcnelson
    jcnelson committed May 22, 2024
    Configuration menu
    Copy the full SHA
    0318fb2 View commit details
    Browse the repository at this point in the history

  15. chore: use reward set signature verification

    @jcnelson
    jcnelson committed May 22, 2024
    Configuration menu
    Copy the full SHA
    4f38a04 View commit details
    Browse the repository at this point in the history

  16. chore: document post-nakamoto usage of aggregate public key

    @jcnelson
    jcnelson committed May 22, 2024
    Configuration menu
    Copy the full SHA
    b0100bc View commit details
    Browse the repository at this point in the history

  17. feat: cache reward sets by reward cycle and sortition ID, instead of … 

    …aggregate public keys
    @jcnelson
    jcnelson committed May 22, 2024
    Configuration menu
    Copy the full SHA
    3de7c89 View commit details
    Browse the repository at this point in the history

  18. chore: API sync; delete dead code (it's in the git history now)

    @jcnelson
    jcnelson committed May 22, 2024
    Configuration menu
    Copy the full SHA
    dc43a27 View commit details
    Browse the repository at this point in the history

  19. chore: use reward sets instead of aggregate public keys

    @jcnelson
    jcnelson committed May 22, 2024
    Configuration menu
    Copy the full SHA
    4d0a1a3 View commit details
    Browse the repository at this point in the history

  20. chore: API sync

    @jcnelson
    jcnelson committed May 22, 2024
    Configuration menu
    Copy the full SHA
    004f3d6 View commit details
    Browse the repository at this point in the history

  21. Merge branch 'feat/header-signer-signatures' into fix/4793

    @jcnelson
    jcnelson committed May 22, 2024
    Configuration menu
    Copy the full SHA
    02b1492 View commit details
    Browse the repository at this point in the history

  22. fix: load the signer reward cycle for the block based on the fact tha… 

    …t the block in reward cycle N at reward cycle index 0 was signed by the signers of reward cycle N - 1
    @jcnelson
    jcnelson committed May 22, 2024
    Configuration menu
    Copy the full SHA
    6e301e3 View commit details
    Browse the repository at this point in the history

  23. fix: check the *ongoing* tenure, not the last-started tenure

    @jcnelson
    jcnelson committed May 22, 2024
    Configuration menu
    Copy the full SHA
    1f1c8dc View commit details
    Browse the repository at this point in the history

  24. feat: add query API for the ongoing tenure in a given sortition (be i… 

    …t an extension of a previously-started tenure, or a newly-started tenure), and clarify that the existing API for getting the highest Nakamoto tenure only pertains to the highest *started* tenure (not extended)
    @jcnelson
    jcnelson committed May 22, 2024
    Configuration menu
    Copy the full SHA
    a99c098 View commit details
    Browse the repository at this point in the history

  25. chore: fmt

    @jcnelson
    jcnelson committed May 22, 2024
    Configuration menu
    Copy the full SHA
    f930538 View commit details
    Browse the repository at this point in the history

  26. chore: document tenure-loading behavior

    @jcnelson
    jcnelson committed May 22, 2024
    Configuration menu
    Copy the full SHA
    480f2fd View commit details
    Browse the repository at this point in the history

  27. chore: fmt

    @jcnelson
    jcnelson committed May 22, 2024
    Configuration menu
    Copy the full SHA
    d2c2847 View commit details
    Browse the repository at this point in the history

  28. chore: mock aggregate public key until the miner is upgraded to not n… 

    …eed it
    @jcnelson
    jcnelson committed May 22, 2024
    Configuration menu
    Copy the full SHA
    b24deed View commit details
    Browse the repository at this point in the history

  29. fix: remove unused var

    @jcnelson
    jcnelson committed May 22, 2024
    Configuration menu
    Copy the full SHA
    bb1aed1 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. chore: address PR feedback

    @jcnelson
    jcnelson committed May 23, 2024
    Configuration menu
    Copy the full SHA
    72b0e2c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into feat/header-signer-signatures

    @jcnelson
    jcnelson authored May 23, 2024
    Configuration menu
    Copy the full SHA
    1091346 View commit details
    Browse the repository at this point in the history

  3. chore: comment on why we need to continuously re-check the preprocess… 

    …ed reward set of the anchor block is not yet known
    @jcnelson
    jcnelson committed May 23, 2024
    Configuration menu
    Copy the full SHA
    91f3545 View commit details
    Browse the repository at this point in the history

  4. crc: typecasting and returning errors instead of panic in `coordinate… 

    …_signature`
    @hstove
    hstove committed May 23, 2024
    Configuration menu
    Copy the full SHA
    6b86b95 View commit details
    Browse the repository at this point in the history

  5. crc: return err instead of fatal when updating next_bitvec

    @hstove
    hstove committed May 23, 2024
    Configuration menu
    Copy the full SHA
    0658bb9 View commit details
    Browse the repository at this point in the history

  6. feat: load reward set in gather_signatures instead of run_miner to … 

    …prevent panics
    @hstove
    hstove committed May 23, 2024
    Configuration menu
    Copy the full SHA
    4cb4d15 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'feat/header-signer-signatures' into feat/miner-gather-v… 

    …0-signatures
    @hstove
    hstove committed May 23, 2024
    Configuration menu
    Copy the full SHA
    4dca885 View commit details
    Browse the repository at this point in the history

  8. feat: remove aggregate key related stuff from sign coordinator

    @hstove
    hstove committed May 23, 2024
    Configuration menu
    Copy the full SHA
    2275aa8 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. chore: address PR feedback

    @jcnelson
    jcnelson committed May 24, 2024
    Configuration menu
    Copy the full SHA
    3dccf40 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. chore: indicate in the docs that the reward set must correspond to th… 

    …e sortition ID
    @jcnelson
    jcnelson committed May 28, 2024
    Configuration menu
    Copy the full SHA
    0e68198 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #4817 from stacks-network/fix/4793 

    Fix/4793
    @jcnelson
    jcnelson authored May 28, 2024
    Configuration menu
    Copy the full SHA
    a70bfb5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into feat/header-signer-signatures

    @jcnelson
    jcnelson authored May 28, 2024
    Configuration menu
    Copy the full SHA
    dbcd10f View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Merge 'feat/header-signer-signatures' into 'feat/miner-gather-v0-sign… 

    …atures'
    @hstove
    hstove committed May 29, 2024
    Configuration menu
    Copy the full SHA
    faa808a View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. feat: additional checks for invalid signatures, duplicates, etc

    @hstove
    hstove committed May 30, 2024
    Configuration menu
    Copy the full SHA
    e968530 View commit details
    Browse the repository at this point in the history

  2. crc: helper method for RewardSet total weight

    @hstove
    hstove committed May 30, 2024
    Configuration menu
    Copy the full SHA
    f963b35 View commit details
    Browse the repository at this point in the history

  3. fix: add missing comma to debug metadata

    @hstove
    hstove committed May 30, 2024
    Configuration menu
    Copy the full SHA
    4c35571 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Merge pull request #4807 from stacks-network/feat/miner-gather-v0-sig… 

    …natures

feat: gather v0 block signatures from stackerdb
    @hstove
    hstove authored May 31, 2024
    Configuration menu
    Copy the full SHA
    ba9df14 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. fix: return errors instead of panics in miner thread

    @hstove
    hstove committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    55567d7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into feat/header-signer-signatures

    @hstove
    hstove committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    1d7c5bd View commit details
    Browse the repository at this point in the history

  3. fix: cargo check --tests errors after merge

    @hstove
    hstove committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    0e59295 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. fix: miner should allow prior miner thread to error

    @kantai
    kantai committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    7c8df31 View commit details
    Browse the repository at this point in the history