Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warn for not using local stacks node with the signer #4782

Merged
merged 8 commits into from
May 22, 2024
Merged

warn for not using local stacks node with the signer #4782

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bd86f0d
warn for not using local stacks node with the signer
ASuciuX May 13, 2024
26e5570
removes annotations and keep warn as 1 displayed line
ASuciuX May 13, 2024
6e373a1
update message as reminder
ASuciuX May 14, 2024
b18e660
add link to documentation
ASuciuX May 17, 2024
39f2b1b
Merge branch 'develop' into feat/bootup-message-signer-local-node
ASuciuX May 17, 2024
b1c0816
update to latest dev with warn signer network
ASuciuX May 17, 2024
396bf42
update link, no markdown supported on stderr out
ASuciuX May 17, 2024
8330eb0
Merge branch 'develop' into feat/bootup-message-signer-local-node
ASuciuX May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions stacks-signer/src/v1/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ use std::sync::mpsc::{channel, Receiver, Sender};

use libsigner::v1::messages::SignerMessage;
use libsigner::SignerEventReceiver;
use slog::slog_info;
use stacks_common::info;
use slog::{slog_info, slog_warn};
use stacks_common::{info, warn};
use wsts::state_machine::OperationResult;

use crate::config::GlobalConfig;
Expand All @@ -53,6 +53,14 @@ pub struct SpawnedSigner {
impl From<GlobalConfig> for SpawnedSigner {
fn from(config: GlobalConfig) -> Self {
let endpoint = config.endpoint;
warn!(
"Reminder: The signer is primarily designed for use with a local or subnet network stacks node. \
It's important to exercise caution if you are communicating with an external node, \
as this could potentially expose sensitive data or functionalities to security risks \
if additional proper security checks are not integrated in place. \
For more information, check the documentation at \
https://docs.stacks.co/nakamoto-upgrade/signing-and-stacking/faq#what-should-the-networking-setup-for-my-signer-look-like."
);
info!("Starting signer with config: {}", config);
let (cmd_send, cmd_recv) = channel();
let (res_send, res_recv) = channel();
Expand Down