Chore/block signature message type #4787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
hstove
previously approved these changes
May 13, 2024
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
jcnelson
reviewed
May 14, 2024
jcnelson
reviewed
May 14, 2024
jcnelson
reviewed
May 14, 2024
jcnelson
reviewed
May 14, 2024
jcnelson
reviewed
May 14, 2024
…rk/stacks-core into chore/block-signature-message-type
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
… into chore/block-signature-message-type
Signed-off-by: Jacinta Ferrant <[email protected]>
kantai
reviewed
May 14, 2024
kantai
previously approved these changes
May 14, 2024
Signed-off-by: Jacinta Ferrant <[email protected]>
kantai
previously approved these changes
May 14, 2024
jcnelson
reviewed
May 14, 2024
jcnelson
previously approved these changes
May 14, 2024
Signed-off-by: Jacinta Ferrant <[email protected]>
kantai
approved these changes
May 14, 2024
jcnelson
approved these changes
May 14, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4784
I made the process_event logic take a generic type which implements StacksMessageCodec to enable having different message types for v1 and v2 without borking up code in each respective path. I also implemented a helper function for creating a v1 signer. This same logic can easily be added for a v0 signer which wraps the super confusing looking RunningSigner struct.