Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skips and comments for certain mutants #4790

Merged

Conversation

@ASuciuX ASuciuX self-assigned this May 15, 2024
@ASuciuX ASuciuX linked an issue May 15, 2024 that may be closed by this pull request
10 tasks
@ASuciuX ASuciuX requested a review from jbencin May 15, 2024 20:41
@ASuciuX ASuciuX requested review from a team as code owners May 15, 2024 21:55
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.24%. Comparing base (b379a0a) to head (e59247d).
Report is 158 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #4790       +/-   ##
============================================
+ Coverage    15.53%   83.24%   +67.71%     
============================================
  Files          476      481        +5     
  Lines       344100   346776     +2676     
  Branches         0      323      +323     
============================================
+ Hits         53460   288683   +235223     
+ Misses      290640    58085   -232555     
- Partials         0        8        +8     
Files Coverage Δ
clarity/src/vm/ast/parser/v1.rs 90.95% <ø> (+64.18%) ⬆️
clarity/src/vm/ast/parser/v2/mod.rs 56.32% <ø> (+56.32%) ⬆️
clarity/src/vm/ast/sugar_expander/mod.rs 94.17% <ø> (+80.71%) ⬆️
clarity/src/vm/costs/mod.rs 81.62% <ø> (+37.40%) ⬆️
clarity/src/vm/types/mod.rs 91.33% <ø> (+66.31%) ⬆️
libsigner/src/events.rs 77.16% <ø> (+77.16%) ⬆️
pox-locking/src/events.rs 96.33% <ø> (+96.33%) ⬆️
stackslib/src/burnchains/db.rs 81.53% <ø> (+10.70%) ⬆️
stackslib/src/burnchains/mod.rs 82.64% <ø> (+24.42%) ⬆️
stackslib/src/chainstate/burn/db/sortdb.rs 91.05% <ø> (+57.90%) ⬆️
... and 10 more

... and 430 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe8ba12...e59247d. Read the comment docs.

jbencin
jbencin previously approved these changes May 16, 2024
stackslib/Cargo.toml Outdated Show resolved Hide resolved
libsigner/Cargo.toml Outdated Show resolved Hide resolved
Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @ASuciuX! Please address the comments and I'll approve.

@ASuciuX ASuciuX requested review from jcnelson and jbencin June 4, 2024 19:08
@ASuciuX ASuciuX requested a review from a team June 5, 2024 18:50
@ASuciuX ASuciuX enabled auto-merge June 6, 2024 15:31
@ASuciuX ASuciuX added this pull request to the merge queue Jun 6, 2024
Merged via the queue into stacks-network:develop with commit 5645949 Jun 6, 2024
1 of 2 checks passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mutations Testing] Highlighting Functions not fully covered by their tests
4 participants