-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Update Used Actions' Versions #4792
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shipit
Moved the setting of the rust toolchain and checkout-ing the code inside composite actions for easier code maintenance, changed in stacks-network/actions#41.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shipit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi - rerunning workflows after the required change was merged in the actions repo |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4792 +/- ##
============================================
+ Coverage 42.93% 60.10% +17.17%
============================================
Files 469 474 +5
Lines 338809 340157 +1348
Branches 0 323 +323
============================================
+ Hits 145456 204442 +58986
+ Misses 193353 135707 -57646
- Partials 0 8 +8 see 333 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
cd1022f
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Updated all marketplace actions to their latest version - the node version that some of them were using was
Node.js 16
, which is deprecated and comes up as a warning in the runners,Node.js 20
being the one used in the latest versions of these actions.Notes:
upload-artifact
action had a change fromv3
tov4
and the workflow is unable to append to the initial artifact when uploading with the same name, and I've made the composite action upload artifacts with different names. Because of this, thedownload-artifact
action had to be updated to only download artifacts with a specific pattern (<tag>-binary-build-*
in the case of release workflow).<tag>-binary-build-*
) togenerate-checksum
composite action, because previously it was downloading an artifact with hardcoded name (artifact
) - which no longer exists (explained above).Example run (the bitcoin test failure is not affected by the changes in this PR): https://github.com/BowTiedDevOps/stacks-core/actions/runs/9082502434
Release after updating the workflows: https://github.com/BowTiedDevOps/stacks-core/releases/tag/2.5.0.0.4-rc4
This PR is to be merged after the
actions
repository one: stacks-network/actions#40