Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update Used Actions' Versions #4792

Merged
merged 4 commits into from
May 15, 2024
Merged

Conversation

BowTiedDevOps
Copy link
Collaborator

Description

Updated all marketplace actions to their latest version - the node version that some of them were using was Node.js 16, which is deprecated and comes up as a warning in the runners, Node.js 20 being the one used in the latest versions of these actions.

Notes:

  • upload-artifact action had a change from v3 to v4 and the workflow is unable to append to the initial artifact when uploading with the same name, and I've made the composite action upload artifacts with different names. Because of this, the download-artifact action had to be updated to only download artifacts with a specific pattern (<tag>-binary-build-* in the case of release workflow).
  • Added input for artifact pattern (<tag>-binary-build-*) to generate-checksum composite action, because previously it was downloading an artifact with hardcoded name (artifact) - which no longer exists (explained above).

Example run (the bitcoin test failure is not affected by the changes in this PR): https://github.com/BowTiedDevOps/stacks-core/actions/runs/9082502434

Release after updating the workflows: https://github.com/BowTiedDevOps/stacks-core/releases/tag/2.5.0.0.4-rc4

This PR is to be merged after the actions repository one: stacks-network/actions#40

@BowTiedDevOps BowTiedDevOps added enhancement Iterations on existing features or infrastructure. CI labels May 14, 2024
@BowTiedDevOps BowTiedDevOps self-assigned this May 14, 2024
CharlieC3
CharlieC3 previously approved these changes May 14, 2024
Copy link
Member

@CharlieC3 CharlieC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

.github/workflows/ci.yml Outdated Show resolved Hide resolved
wileyj
wileyj previously approved these changes May 14, 2024
Copy link
Contributor

@wileyj wileyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@wileyj wileyj enabled auto-merge May 14, 2024 22:14
@wileyj wileyj disabled auto-merge May 14, 2024 22:26
@BowTiedDevOps BowTiedDevOps dismissed stale reviews from wileyj and CharlieC3 via 9f7c023 May 14, 2024 23:03
@BowTiedDevOps
Copy link
Collaborator Author

BowTiedDevOps commented May 14, 2024

Moved the setting of the rust toolchain and checkout-ing the code inside composite actions for easier code maintenance, changed in stacks-network/actions#41.
Closes #4794

Example run (rustfmt): https://github.com/BowTiedDevOps/stacks-core/actions/runs/9087322966/job/24974854258 (failed due to shutdown signal)
Example run (rustfmt): https://github.com/BowTiedDevOps/stacks-core/actions/runs/9087482799/job/24975291331

Copy link
Contributor

@wileyj wileyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

Copy link
Member

@CharlieC3 CharlieC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@wileyj
Copy link
Contributor

wileyj commented May 15, 2024

fyi - rerunning workflows after the required change was merged in the actions repo

@wileyj wileyj enabled auto-merge May 15, 2024 14:55
@wileyj wileyj added this pull request to the merge queue May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.10%. Comparing base (7d40753) to head (406083a).
Report is 27 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #4792       +/-   ##
============================================
+ Coverage    42.93%   60.10%   +17.17%     
============================================
  Files          469      474        +5     
  Lines       338809   340157     +1348     
  Branches         0      323      +323     
============================================
+ Hits        145456   204442    +58986     
+ Misses      193353   135707    -57646     
- Partials         0        8        +8     

see 333 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45cf912...406083a. Read the comment docs.

Merged via the queue into stacks-network:develop with commit cd1022f May 15, 2024
1 of 2 checks passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI enhancement Iterations on existing features or infrastructure. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants