Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/StackerDB Audit #4821

Merged
merged 4 commits into from
May 28, 2024
Merged

Fix/StackerDB Audit #4821

merged 4 commits into from
May 28, 2024

Conversation

jcnelson
Copy link
Member

This addresses all of the points brought forth by a StackerDB audit. None of them are security risks or pose a serious problem to the system's operation, so it's safe to just open it against develop for now without doing a hotfix.

The fixes are:

  • Don't accept a private IP address from hint-replicas in the StackerDB config contract
  • Limit the upper value of max-neighbors to the locally-configured num_neighbors in ConnectionOptions

@jcnelson jcnelson requested a review from a team as a code owner May 23, 2024 20:49
jferrant
jferrant reviewed May 24, 2024
View reviewed changes
Copy link
Collaborator

@jferrant jferrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think missed a change in neon_node.rs (caught by github), but aside from that LGTM

@obycode obycode self-requested a review May 24, 2024 14:05
obycode
obycode reviewed May 24, 2024
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, just need to fix the issue preventing the tests from running.

obycode
obycode approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jcnelson jcnelson added this pull request to the merge queue May 28, 2024
Merged via the queue into develop with commit a4eb590 May 28, 2024
1 check passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jferrant jferrant jferrant approved these changes

@obycode obycode obycode approved these changes

Assignees
No one assigned
Labels
3.0-must locked nakamoto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcnelson @blockstack-devops @obycode @jferrant