…types

- Added import for StackStxSigCommand_Err and StackStxAuthCommand_Err
- Added StackStxAuthCommand_Err with a custom check function delegate to
  PoxCommands
- Added StackStxSigCommand_Err with a custom check function delegate to
  PoxCommands

This allows the check function to be parameterized, reducing the need for
copy-pasting classes.

Note: This is a very work in progress.

…types

- Separate success paths from failure paths to keep pox_Commands.ts focused
  on success cases only. This prevents the file from growing with
  out-of-scope cases.

Note: This is a work in progress.

The command run tracking will be added to the command's `check` method.

If not passed incremented, the call will result in an `ERR_INVALID_START_BURN_HEIGHT` when being sent at the limit between 2 cycles.

This commit:
- adds 6 unhappy path cases for the `stack-stx` PoX-4 method, 3 for each signing method (authorization or signature)
- adds a dictionary that contains the PoX-4 error names and the error codes
- adds the command run tracking inside the `check` method, resulting in displaying all the paths hit and the number of times.

They needed to be excluded as we have removed the command run tracking from the run method.

The added unhappy path tries to call revoke-delegate-stx with an address that is not delegating.

The command run tracking was moved inside the command's check function. No need to report the run using the file name anymore.

The added unhappy path tries to call delegate-stx with an address that is already delegating.

The command run tracking was moved inside the command's check function. No need to report the run using the file name anymore.

This commit:
- includes the authorization and the function call in the same block. It is needed because otherwise, it can result in issuing the authorization for the wrong reward cycle.
- updates the passed start-burn-ht param, different from the StackStxSigCommand. If not doing it like this, the test fails when the command is called at the limit between 2 reward cycles.
- removes unnecessary operations: retrieving the reward cycle, retrieving the unlockBurnHeight.

This commit:
- adds 3 unhappy path cases for the `stack-aggregation-commit` PoX-4 method, called using a signature.
- adds the command run tracking inside the `check` method.
- adds the expected `stack-aggregation-commit` PoX-4 errors to the POX_4_ERRORS dictionary.

The command run tracking was moved inside the command's check function. No need to report the run using the file name anymore.

This commit:
- adds 3 unhappy path cases for the `stack-aggregation-commit` PoX-4 method, called using an authorization.
- adds the command run tracking inside the `check` method.

The command run tracking was moved inside the command's check function. No need to report the run using the file name anymore.

This commit improves the unhappy paths execution visibility after the test suite run is complete.

This commit:
- adds 3 unhappy path cases for the `stack-aggregation-commit-indexed` PoX-4 method, called using a signature.
- adds the command run tracking inside the `check` method.

This commit:
- adds 3 unhappy path cases for the `stack-aggregation-commit-indexed` PoX-4 method, called using an authorization.
- adds the command run tracking inside the `check` method.

The command run tracking for the unhappy paths was moved inside the commands' check function. No need to report the run using the file name anymore.

This commit:
- adds one unhappy path case for the `stack-aggregation-increase` PoX-4 method, called using an authorization.
- adds the command run tracking inside the `check` method.

This commit:
- adds 3 unhappy path cases for the `delegate-stack-stx` PoX-4 method.
- adds the command run tracking inside the `check` method.
- adds the expected `delegate-stack-stx` PoX-4 errors to the `POX_4_ERRORS` dictionary.
- exports the `nextCycleFirstBlock` method from pox_commands, as it is used inside err_Commands.

This commit:
- adds 3 unhappy path cases for the `stack-increase` PoX-4 method, called using a signature.
- adds the command run tracking inside the `check` method.
- adds the expected `stack-increase` PoX-4 errors to the `POX_4_ERRORS` dictionary.

This commit:
- adds 3 unhappy path cases for the `stack-increase` PoX-4 method, called using an authorization.
- adds the command run tracking inside the `check` method.

This commit:
- adds 5 unhappy path cases for the `stack-increase` PoX-4 method, called using a signature.
- adds the command run tracking inside the `check` method.
- adds the expected `stack-extend` PoX-4 errors to the `POX_4_ERRORS` dictionary.

This commit:
- adds 5 unhappy path cases for the `stack-extend` PoX-4 method, called using an authorization.
- adds the command run tracking inside the `check` method.

This commit:
- adds 4 unhappy path cases for the `delegate-stack-extend` PoX-4 method.
- adds the command run tracking inside the `check` method.
- adds the expected `delegate-stack-extend` PoX-4 error to the `POX_4_ERRORS` dictionary.

…types

- Added import for StackStxSigCommand_Err and StackStxAuthCommand_Err
- Added StackStxAuthCommand_Err with a custom check function delegate to
  PoxCommands
- Added StackStxSigCommand_Err with a custom check function delegate to
  PoxCommands

This allows the check function to be parameterized, reducing the need for
copy-pasting classes.

Note: This is a very work in progress.

…types

- Separate success paths from failure paths to keep pox_Commands.ts focused
  on success cases only. This prevents the file from growing with
  out-of-scope cases.

Note: This is a work in progress.

The command run tracking will be added to the command's `check` method.

If not passed incremented, the call will result in an `ERR_INVALID_START_BURN_HEIGHT` when being sent at the limit between 2 cycles.

This commit:
- adds 6 unhappy path cases for the `stack-stx` PoX-4 method, 3 for each signing method (authorization or signature)
- adds a dictionary that contains the PoX-4 error names and the error codes
- adds the command run tracking inside the `check` method, resulting in displaying all the paths hit and the number of times.

They needed to be excluded as we have removed the command run tracking from the run method.

The added unhappy path tries to call revoke-delegate-stx with an address that is not delegating.

The command run tracking was moved inside the command's check function. No need to report the run using the file name anymore.

The added unhappy path tries to call delegate-stx with an address that is already delegating.

The command run tracking was moved inside the command's check function. No need to report the run using the file name anymore.

This commit:
- includes the authorization and the function call in the same block. It is needed because otherwise, it can result in issuing the authorization for the wrong reward cycle.
- updates the passed start-burn-ht param, different from the StackStxSigCommand. If not doing it like this, the test fails when the command is called at the limit between 2 reward cycles.
- removes unnecessary operations: retrieving the reward cycle, retrieving the unlockBurnHeight.

This commit:
- adds 3 unhappy path cases for the `stack-aggregation-commit` PoX-4 method, called using a signature.
- adds the command run tracking inside the `check` method.
- adds the expected `stack-aggregation-commit` PoX-4 errors to the POX_4_ERRORS dictionary.

The command run tracking was moved inside the command's check function. No need to report the run using the file name anymore.

This commit:
- adds 3 unhappy path cases for the `stack-aggregation-commit` PoX-4 method, called using an authorization.
- adds the command run tracking inside the `check` method.

The command run tracking was moved inside the command's check function. No need to report the run using the file name anymore.

This commit improves the unhappy paths execution visibility after the test suite run is complete.

This commit:
- adds 3 unhappy path cases for the `stack-aggregation-commit-indexed` PoX-4 method, called using a signature.
- adds the command run tracking inside the `check` method.

This commit:
- adds 3 unhappy path cases for the `stack-aggregation-commit-indexed` PoX-4 method, called using an authorization.
- adds the command run tracking inside the `check` method.

The command run tracking for the unhappy paths was moved inside the commands' check function. No need to report the run using the file name anymore.

This commit:
- adds one unhappy path case for the `stack-aggregation-increase` PoX-4 method, called using an authorization.
- adds the command run tracking inside the `check` method.

This commit:
- adds 3 unhappy path cases for the `delegate-stack-stx` PoX-4 method.
- adds the command run tracking inside the `check` method.
- adds the expected `delegate-stack-stx` PoX-4 errors to the `POX_4_ERRORS` dictionary.
- exports the `nextCycleFirstBlock` method from pox_commands, as it is used inside err_Commands.

This commit:
- adds 3 unhappy path cases for the `stack-increase` PoX-4 method, called using a signature.
- adds the command run tracking inside the `check` method.
- adds the expected `stack-increase` PoX-4 errors to the `POX_4_ERRORS` dictionary.

This commit:
- adds 3 unhappy path cases for the `stack-increase` PoX-4 method, called using an authorization.
- adds the command run tracking inside the `check` method.

This commit:
- adds 5 unhappy path cases for the `stack-increase` PoX-4 method, called using a signature.
- adds the command run tracking inside the `check` method.
- adds the expected `stack-extend` PoX-4 errors to the `POX_4_ERRORS` dictionary.

This commit:
- adds 5 unhappy path cases for the `stack-extend` PoX-4 method, called using an authorization.
- adds the command run tracking inside the `check` method.

This commit:
- adds 4 unhappy path cases for the `delegate-stack-extend` PoX-4 method.
- adds the command run tracking inside the `check` method.
- adds the expected `delegate-stack-extend` PoX-4 error to the `POX_4_ERRORS` dictionary.

…thub.com/stacks-network/stacks-core into feat/pox-4-stateful-prop-tests-check-err

This commit adds the undefined check in the `err_Commands` comparisons that involve `delegatedUntilBurnHt`.

This commit:
- adds 4 unhappy path cases for the `delegate-stack-increase` PoX-4 method.
- adds the command run tracking inside the `check` method.

This commit:
- adds one unhappy path case for the `disallow-contract-caller` PoX-4 method.
- adds the command run tracking inside the `check` method.

This commit brings typo fixes for all the comments inside the PoX-4 stateful property tests.

This update simplifies the err_Commands generators file.

The added condition ensures that an active lock does not expire at the end of the current cycle, and avoids the PoX-4 Clarity error 2 - ERR_STACKING_INVALID_LOCK_PERIOD

This commit refactors all the unhappy path check functions, returning early the false and removing the else branch.

This commit:
- simplifies the way firstRewardCycle is calculated, replacing the ternary operator with the max Math method.
- standardizes the const name of the stacker retrieved from the model.

… testing environment