feat: add timestamp to nakamoto block header
#4846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obycode
force-pushed
the
feat/naka-timestamp
branch
2 times, most recently
from
d18f0c9
to
7b58613
Compare
`(get-block-info? time block-height)` uses this new timestamp in Clarity 3, instead of using the timestamp from the burn block.
obycode
force-pushed
the
feat/naka-timestamp
branch
from
7b58613
to
ddbb51f
Compare
Since the boot contracts use 32, when the config is set to 16, this causes many warnings.
|
Remaining todo item: we should be able to call |
Change back to `height_value > current_tenure` after the current tenure support is fixed.
kantai
previously approved these changes
Jun 21, 2024
jcnelson
previously approved these changes
Jun 21, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
jcnelson
approved these changes
Jun 21, 2024
kantai
approved these changes
Jun 21, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(get-block-info? time block-height)uses this new timestamp in Clarity 3, instead of using the timestamp from the burn block. The signers will validate that this timestamp is:Applicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/rpc/openapi.yamlandrpc-endpoints.mdfor v2 endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepobitcoin-tests.yml