Fix: block commit pox-descendant check in nakamoto #4927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jferrant
previously approved these changes
Jun 28, 2024
|
Thanks for finding this Aaron. Is this at all related to the change I made that had to do with how to select the parent to build atop of in the forked_tenure test? Specifically #4674 ? (asking for my own clarity of the situation) |
jcnelson
previously approved these changes
Jun 28, 2024
I don't think so-- at least not directly related. This issue ended up being kind of downstream of some other issues in the testnet, but it was the issue that led to the testnet stalling out completely. |
obycode
approved these changes
Jun 28, 2024
jcnelson
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue that showed up in the naka-1 testnet. The leader block commit op in nakamoto is committing to a parent block, not a new block, so there was previously essentially an "off by one" bug in the block commit op evaluation.
This also adds a test for this behavior.