Fix/4938 #4939
Merged
Fix/4938 #4939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and enforce submitting to the node for validation Signed-off-by: Jacinta Ferrant <[email protected]>
|
Added a test that enforces that the fetch view sortition check returns a valid last sortition (would terminate early with a "NoSortitionView" error otherwise) and we pass local validation checks to force an RPC call to the node. Closes #4941 as well. |
kantai
reviewed
Jul 3, 2024
Signed-off-by: Jacinta Ferrant <[email protected]>
kantai
approved these changes
Jul 5, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4938 by requiring that the last block snapshot with a sortiiton be returned from /v3/sortitions.