-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(signer): Add enum for version-specific data to BlockInfo
#4981
refactor(signer): Add enum for version-specific data to BlockInfo
#4981
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of using an enum for version specific data here, but I think this breaks v0
at the moment: signed_over
is used to indicate whether or not a block has been signed by the local node. Maybe it would make sense to add a new field to the v0
enum for this, or maybe the signed_over
field should just move back into the common struct.
66d3eb2
to
ef45a38
Compare
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Add enum for version-specific (Signer v0 or v1) data to
BlockInfo
Applicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/rpc/openapi.yaml
andrpc-endpoints.md
for v2 endpoints,event-dispatcher.md
for new events)clarity-benchmarking
repobitcoin-tests.yml