Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support resuming from a saved VRF key #4996

Merged
merged 8 commits into from
Jul 25, 2024
Merged

feat: support resuming from a saved VRF key #4996

merged 8 commits into from
Jul 25, 2024

Conversation

obycode
Copy link
Contributor

@obycode obycode commented Jul 23, 2024

I still need to add a test for this. Unit tests added.

Fixes #4994.

@saralab saralab requested review from jcnelson and kantai July 23, 2024 13:52
This allows the key to be reused on miner restart. This functionality is
already available in the neon node, and is now added to the nakamoto
node.
@obycode obycode marked this pull request as ready for review July 23, 2024 21:58
@obycode obycode requested a review from a team as a code owner July 23, 2024 21:58
jcnelson
jcnelson previously approved these changes Jul 24, 2024
Copy link
Member

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just suggesting that you drop one of the debug logs

testnet/stacks-node/src/nakamoto_node/relayer.rs Outdated Show resolved Hide resolved
@obycode obycode added this pull request to the merge queue Jul 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 25, 2024
@obycode obycode enabled auto-merge July 25, 2024 20:36
@obycode obycode added this pull request to the merge queue Jul 25, 2024
Merged via the queue into develop with commit 5acf6c5 Jul 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants