Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/move signer logs to info #5014

Merged
merged 7 commits into from
Jul 30, 2024
Merged

Conversation

ASuciuX
Copy link
Contributor

@ASuciuX ASuciuX commented Jul 26, 2024

Description

Moves from debug to info some of the most relevant logs in order to be displayed on signers with the default logs level. If switched to debug they would have to many logs and have to know how to read through them.

Applicable issues

Checklist

@ASuciuX ASuciuX requested a review from obycode July 26, 2024 11:25
@ASuciuX ASuciuX self-assigned this Jul 26, 2024
@ASuciuX ASuciuX requested a review from a team as a code owner July 26, 2024 11:25
@ASuciuX
Copy link
Contributor Author

ASuciuX commented Jul 26, 2024

@obycode in the first commit I also added the block proposal and block validation, but those are related to stacks blocks and it will display pretty frequent if we include them.

wileyj
wileyj previously approved these changes Jul 26, 2024
@saralab saralab requested a review from jferrant July 29, 2024 15:15
@obycode
Copy link
Contributor

obycode commented Jul 29, 2024

I'd prefer to keep those stacks block logs as info.

@ASuciuX
Copy link
Contributor Author

ASuciuX commented Jul 29, 2024

I'd prefer to keep those stacks block logs as info.

Ok, I'll update it to contain those from the 1st commit as well.

@ASuciuX ASuciuX requested a review from obycode July 30, 2024 13:55
wileyj
wileyj previously approved these changes Jul 30, 2024
Copy link
Contributor

@wileyj wileyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wileyj wileyj added this pull request to the merge queue Jul 30, 2024
Merged via the queue into develop with commit 98b7d3d Jul 30, 2024
1 check passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

5 participants