-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oneliner to set signer version at compile time with STACKS_NODE_VERSION #5016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with @ASuciuX help, we found a way to return the desired version output in the format that Clap was expecting. |
kantai
reviewed
Jul 29, 2024
jferrant
approved these changes
Jul 29, 2024
obycode
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
kantai
approved these changes
Jul 30, 2024
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #5002
This is the minimally viable change to allow setting the signer version at build time, defaulting to
CARGO_PKG_VERSION
.Since the signer already uses the same build process as stacks-core, the correct version will already be set as
STACKS_NODE_VERSION
, so that is why that env var is used here vs something more suited likeSIGNER_VERSION
.using
SIGNER_VERSION
would simply require some downstream changes (mainly to CI workflows), but is trivial if that env var is desired.I did set out to try and expose a version string like
/v2/info
, but due to how Clap was expecting a str, i wasn't able to get all the desired values returned correctly.this is what i tried to emulate
/v2/info
with, but wasn't able to figure out how to return the full output as a str:formatted
prints the expected output:but Clap is expecting it to be a str.