Test: multiple miner nakamoto_integration test #5019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chunks should not retry indefinitely; check for the absence of neighbors to sync to as a stopping condition for pushchunks
* test: add nakamoto_integration test with multiple miners (this test uses the blind signer test signing channel) * fix: nakamoto miner communicates over the correct miner slot for their block election (rather than searching by pubkey) * fix: neon miner does not submit block commits if the next burn block is in nakamoto * feat: update `/v2/neighbors` to use qualified contract identifier's ToString and parse() for JSON serialization * perf: nakamoto miner caches the reward set for their tenure
kantai
force-pushed
the
test/multi-miner-cleanup
branch
from
ab41822
to
7c7f9b3
Compare
jcnelson
previously approved these changes
Jul 29, 2024
obycode
reviewed
Jul 29, 2024
jcnelson
approved these changes
Jul 29, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a multiple miner integration test to the
nakamoto_integrationssuite. This test doesn't use the signer set (it uses the test signing channel). I'm planning on working on adding that to the signer integration test suite in a separate PR (this PR already includes a number of fixes).As part of getting this integration test suite to work, this PR does the following:
There's also a change to the output of
v2/neighbors:/v2/neighborsto use qualified contract identifier's ToString and parse() for JSON serializationThis makes that JSON output much more readable.