Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/mock signing in 2.5 #5020

Merged
merged 9 commits into from
Jul 31, 2024
Merged

Feat/mock signing in 2.5 #5020

merged 9 commits into from
Jul 31, 2024

Conversation

jferrant
Copy link
Collaborator

@jferrant jferrant commented Jul 29, 2024

Partially closes #4984

Copy link
Member

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some superficial comments.

Otherwise, yes, I think we should add some more data to the MockSignature struct like:

pub struct MockSignature {
   signature: ...,
   data: MockSignData
}

pub struct MockSignData {
   stacks_tip_consensus_hash: ConsensusHash,
   stacks_tip: BlockHeaderHash,
   server_version: String,
   burn_block_height: u64,
   pox_consensus: ConsensusHash, 
}

Then, yes, its fine if your test just asserts using the burn_block_height.

testnet/stacks-node/src/tests/signer/v0.rs Outdated Show resolved Hide resolved
…signature struct, and update integration test to use burn block height

Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant jferrant requested a review from kantai July 30, 2024 18:16
@jferrant jferrant marked this pull request as ready for review July 30, 2024 18:16
@jferrant jferrant requested review from a team as code owners July 30, 2024 18:16
@jferrant jferrant changed the title WIP: Feat/mock signing in 2.5 Feat/mock signing in 2.5 Jul 30, 2024
jcnelson
jcnelson previously approved these changes Jul 30, 2024
kantai
kantai previously approved these changes Jul 30, 2024
@jferrant jferrant added this pull request to the merge queue Jul 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jul 30, 2024
@jferrant jferrant dismissed stale reviews from kantai and jcnelson via cad5eea July 30, 2024 19:19
@jferrant jferrant requested review from jcnelson and kantai July 30, 2024 19:19
@jferrant jferrant enabled auto-merge July 30, 2024 19:20
kantai
kantai previously approved these changes Jul 30, 2024
jcnelson
jcnelson previously approved these changes Jul 30, 2024
@jferrant jferrant added this pull request to the merge queue Jul 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 30, 2024
@jferrant jferrant dismissed stale reviews from jcnelson and kantai via c394a08 July 31, 2024 11:14
@jferrant jferrant requested review from jcnelson and kantai July 31, 2024 11:18
@jferrant jferrant requested a review from kantai July 31, 2024 15:00
@jferrant jferrant added this pull request to the merge queue Jul 31, 2024
Merged via the queue into develop with commit 608ad7a Jul 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants