-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/mock signing in 2.5 #5020
Merged
Merged
Feat/mock signing in 2.5 #5020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
kantai
reviewed
Jul 30, 2024
kantai
reviewed
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some superficial comments.
Otherwise, yes, I think we should add some more data to the MockSignature struct like:
pub struct MockSignature {
signature: ...,
data: MockSignData
}
pub struct MockSignData {
stacks_tip_consensus_hash: ConsensusHash,
stacks_tip: BlockHeaderHash,
server_version: String,
burn_block_height: u64,
pox_consensus: ConsensusHash,
}
Then, yes, its fine if your test just asserts using the burn_block_height
.
… into feat/mock-signing-in-2.5
…signature struct, and update integration test to use burn block height Signed-off-by: Jacinta Ferrant <[email protected]>
jcnelson
previously approved these changes
Jul 30, 2024
kantai
previously approved these changes
Jul 30, 2024
… into feat/mock-signing-in-2.5
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Jul 30, 2024
… into feat/mock-signing-in-2.5
kantai
previously approved these changes
Jul 30, 2024
jcnelson
previously approved these changes
Jul 30, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jul 30, 2024
… into feat/mock-signing-in-2.5
jcnelson
approved these changes
Jul 31, 2024
kantai
reviewed
Jul 31, 2024
kantai
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially closes #4984