Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: multi-miner & multi-signer scenario #5023

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Conversation

kantai
Copy link
Member

@kantai kantai commented Jul 30, 2024

This adds a new testing scenario to the integration suite for v0::signer: setting up a multiple stacks-node network with 2 miners. The signer set's event listeners (and RPC invocations) are split between the two stacks-nodes.

This test just produces bitcoin blocks and waits for block processing. It asserts that both nodes end the test with the same chain height and that they produced tenures in each bitcoin block in nakamoto.

* assert that both stacks-nodes have same chain height, and that they produced blocks in each bitcoin block of nakamoto
* signers are distributed as event observers across 2 stacks-nodes
@kantai kantai requested review from a team as code owners July 30, 2024 17:47
@wileyj
Copy link
Contributor

wileyj commented Jul 30, 2024

ci change is fine, but i'll hold off approving until someone better suited evaluates the code changes.

obycode
obycode previously approved these changes Jul 30, 2024
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great

wileyj
wileyj previously approved these changes Jul 30, 2024
@kantai kantai dismissed stale reviews from wileyj and obycode via a411098 July 31, 2024 16:51
@kantai kantai enabled auto-merge July 31, 2024 18:21
@kantai kantai requested review from obycode and wileyj July 31, 2024 18:21
@kantai kantai added this pull request to the merge queue Aug 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 1, 2024
@kantai kantai added this pull request to the merge queue Aug 1, 2024
Merged via the queue into develop with commit e3b8e29 Aug 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants