Test/4976 signer set handoff #5037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacinta Ferrant <[email protected]>
hstove
commented
Aug 1, 2024
obycode
reviewed
Aug 5, 2024
kantai
previously approved these changes
Aug 6, 2024
kantai
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an integration test for handling signer set handoffs.
In this test, we boot up a signer test as usual with 5 signers. I've made modifications to only stack for one cycle in this test. 4 other signers are also spun up, but they aren't stacked yet. During the first Nakamoto cycle, the new signers are stacked. This integration test ensures that everything behaves smoothly when the new signer set is completely different than a previous one.
NB: I'm opening this in draft state, because I'm hitting some issues that I believe are bugs in the miner's reward set loading behavior. I'll leave comments on the relevant code.