Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix the empty_sortitions signers test in CI #5050

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

kantai
Copy link
Member

@kantai kantai commented Aug 6, 2024

Description

This fixes the empty_sortitions integration test in CI.

Locally, this worked before because the signers stackerdb updated quickly enough, but the slower timing of CI would read the prior block responses. Now, the test waits until it gets rejections from all the signers.

@kantai kantai requested a review from a team as a code owner August 6, 2024 19:58
Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending a CI pass

@jcnelson jcnelson added this pull request to the merge queue Aug 7, 2024
Merged via the queue into develop with commit 8adec6d Aug 7, 2024
1 check passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants