Feat/mock signing revamp #5070
Merged
Feat/mock signing revamp #5070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacinta Ferrant <[email protected]>
…erdb Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
…ro message Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
jferrant
force-pushed
the
feat/mock-signature-aggregation
branch
from
cb00ad2
to
993d55b
Compare
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
jcnelson
reviewed
Aug 15, 2024
jcnelson
reviewed
Aug 15, 2024
jcnelson
reviewed
Aug 15, 2024
jcnelson
reviewed
Aug 15, 2024
jcnelson
reviewed
Aug 15, 2024
There was a problem hiding this comment.
Overall this looks good, but I think you can avoid creating PeerNetwork over and over again. I also don't think it's safe to change the number of miner slots -- nodes today already think that there are two slots, so nodes that don't run this version will not sync their .miners stackerdb with nodes that do.
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
…ck signing Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
obycode
previously approved these changes
Aug 16, 2024
hstove
previously approved these changes
Aug 16, 2024
jcnelson
previously approved these changes
Aug 16, 2024
Signed-off-by: Jacinta Ferrant <[email protected]>
…to mock signing using it for mock proposals Signed-off-by: Jacinta Ferrant <[email protected]>
hstove
previously approved these changes
Aug 16, 2024
Signed-off-by: Jacinta Ferrant <[email protected]>
obycode
approved these changes
Aug 16, 2024
hstove
approved these changes
Aug 19, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5056