-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.5.0.0.6 update ci #5071
2.5.0.0.6 update ci #5071
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, but want to double check my comment about if we should be removing stacks-signer
from the non-signer Docker builds. Apologies if I've read that wrong!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤞 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Brings in changes from @BowTiedDevOps which creates the tag and runs the release workflows (pushed to develop, but missing in
master
whichrelease/2.5.0.0.6
is based off of): #4968Modifies the ci workflows to disable building the standalone signer image, and uses a specific branch to create the release binary archives with a hardcode list of binaries (no signer binary).
ex: https://github.com/stacks-network/actions/blob/feat/specific_binaries_stacks-core/stacks-core/create-source-binary/build-scripts/Dockerfile.linux-glibc-arm64#L24
This will create conflicts on a future merge, but it's manageable.