Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.5.0.0.6 update ci #5071

Merged
merged 9 commits into from
Aug 14, 2024
Merged

2.5.0.0.6 update ci #5071

merged 9 commits into from
Aug 14, 2024

Conversation

wileyj
Copy link
Contributor

@wileyj wileyj commented Aug 13, 2024

Brings in changes from @BowTiedDevOps which creates the tag and runs the release workflows (pushed to develop, but missing in master which release/2.5.0.0.6 is based off of): #4968

Modifies the ci workflows to disable building the standalone signer image, and uses a specific branch to create the release binary archives with a hardcode list of binaries (no signer binary).
ex: https://github.com/stacks-network/actions/blob/feat/specific_binaries_stacks-core/stacks-core/create-source-binary/build-scripts/Dockerfile.linux-glibc-arm64#L24

This will create conflicts on a future merge, but it's manageable.

@wileyj wileyj requested review from a team as code owners August 13, 2024 20:20
@wileyj wileyj changed the title .5.0.0.6 update ci 2.5.0.0.6 update ci Aug 13, 2024
Copy link
Contributor

@hstove hstove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, but want to double check my comment about if we should be removing stacks-signer from the non-signer Docker builds. Apologies if I've read that wrong!

@hstove hstove self-requested a review August 14, 2024 14:38
Copy link
Member

@CharlieC3 CharlieC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@wileyj wileyj merged commit 7f8b750 into release/2.5.0.0.6 Aug 14, 2024
1 check passed
@wileyj
Copy link
Contributor Author

wileyj commented Aug 14, 2024

🤞

@wileyj wileyj deleted the chore/2.5.0.0.6-update_ci branch August 14, 2024 21:49
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants