Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a config option and wait a minimum number of seconds between mini… #5095

Merged
merged 4 commits into from
Aug 23, 2024

Conversation

jferrant
Copy link
Collaborator

@jferrant jferrant commented Aug 20, 2024

Closes #5080

…ng blocks to prevent signers rejecting a block with same timestamp as its parent

Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant jferrant marked this pull request as ready for review August 20, 2024 20:58
@jferrant jferrant requested review from a team as code owners August 20, 2024 20:58
Copy link
Contributor

@hstove hstove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly a request about changing where we call the wait... function. Otherwise LGTM!

testnet/stacks-node/src/nakamoto_node/miner.rs Outdated Show resolved Hide resolved
testnet/stacks-node/src/nakamoto_node/miner.rs Outdated Show resolved Hide resolved
@obycode obycode added this pull request to the merge queue Aug 23, 2024
Merged via the queue into develop with commit 47a2b14 Aug 23, 2024
1 check passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants